third_party/libaddressinput/chromium/cpp/test/fake_storage.cc - Issue 148463003: libaddressinput - reduce number of copies in storage class by 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/test/fake_storage.cc

Issue 148463003: libaddressinput - reduce number of copies in storage class by 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libaddressinput/chromium/cpp/test/fake_storage.cc

diff --git a/third_party/libaddressinput/chromium/cpp/test/fake_storage.cc b/third_party/libaddressinput/chromium/cpp/test/fake_storage.cc

index 531b23d14718a6738e0635404e8bc89b06e7a8ee..2511b396339cd821afe53e6fd7a7498f70221d91 100644

--- a/third_party/libaddressinput/chromium/cpp/test/fake_storage.cc

+++ b/third_party/libaddressinput/chromium/cpp/test/fake_storage.cc

@@ -24,8 +24,8 @@ FakeStorage::FakeStorage() {}

FakeStorage::~FakeStorage() {}

-void FakeStorage::Put(const std::string& key, const std::string& data) {

- data_[key] = data;

+void FakeStorage::Put(const std::string& key, scoped_ptr<std::string> data) {

+ data_[key] = *data;

}

void FakeStorage::Get(const std::string& key,