Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/libaddressinput/chromium/cpp/src/retriever.cc

Issue 148463003: libaddressinput - reduce number of copies in storage class by 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/src/retriever.cc
diff --git a/third_party/libaddressinput/chromium/cpp/src/retriever.cc b/third_party/libaddressinput/chromium/cpp/src/retriever.cc
index 7e0da10aba2692604a65f6c4fe923d59f7a1aeb8..9287677e76f98647c17fc23cbc5a6fe150015864 100644
--- a/third_party/libaddressinput/chromium/cpp/src/retriever.cc
+++ b/third_party/libaddressinput/chromium/cpp/src/retriever.cc
@@ -211,8 +211,7 @@ void Retriever::OnDownloaded(bool success,
if (success) {
InvokeCallbackForKey(key, success, *downloaded_data);
AppendTimestamp(downloaded_data.get());
- // TODO(estade): storage should take a scoped_ptr.
- storage_->Put(key, *downloaded_data);
+ storage_->Put(key, downloaded_data.Pass());
} else if (stale_data_it != stale_data_.end()) {
InvokeCallbackForKey(key, true, stale_data_it->second);
} else {

Powered by Google App Engine
This is Rietveld 408576698