third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h - Issue 148463003: libaddressinput - reduce number of copies in storage class by 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h

Issue 148463003: libaddressinput - reduce number of copies in storage class by 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/libaddressinput/chromium/chrome_storage_impl.cc ('k') | third_party/libaddressinput/chromium/cpp/src/retriever.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h

diff --git a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h

index 95ff3cabee0a5a6198b75425b100b70f88d278d8..213c66b3660eededdeb20f32f9fc0dd86056d004 100644

--- a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h

+++ b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h

@@ -47,7 +47,7 @@ class Storage {

virtual ~Storage() {}

// Stores |data| for |key|.

- virtual void Put(const std::string& key, const std::string& data) = 0;

+ virtual void Put(const std::string& key, scoped_ptr<std::string> data) = 0;

// Retrieves the data for |key| and invokes the |data_ready| callback.

virtual void Get(const std::string& key,