mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a
RenderWidgetMusConnection, and prior to notification of embedding in
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a
mechanism to create a WindowSurface prior to the availability of a
Window. When creating a WindowSurface, a sibling object,
WindowSurfaceBinding is also created that can be passed into
Window::AttachSurface once a mus::Window is available.

BUG=551250
Committed: https://crrev.com/e5c09bb427330401fc089989fccc16f9ea971664
Cr-Commit-Position: refs/heads/master@{#362273}

[Fady Samuel, 2015-11-27 19:08:43]

fsamuel@chromium.org changed reviewers:
+ sadrul@chromium.org

[Fady Samuel, 2015-11-27 20:19:26]

Added ThreadChecker to WindowSurface. PTAL Sadrul!

[sadrul, 2015-11-27 21:21:37]

I stared at this for a while, and couldn't think of a better approach that
doesn't involve allowing the use of WindowSurface from two separate threads. So
this lgtm

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/c...
File components/mus/public/cpp/window_surface.h (right):

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/c...
components/mus/public/cpp/window_surface.h:61: class WindowSurfaceBinding {
Document

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/i...
File components/mus/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/i...
components/mus/public/interfaces/window_tree.mojom:118: // Attaches a Surface
for a particular window.
*to

[sadrul, 2015-11-27 21:22:22]

Oh, you should update the CL description to explain where this will be used.

[Fady Samuel, 2015-11-27 23:31:39]

Patchset #5 (id:80001) has been deleted

[Fady Samuel, 2015-11-28 21:24:22]

Description was changed from

==========
mus: Introduce AttachToSurface to allow creating Surface prior to OnEmbed

BUG=551250
==========

to

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

BUG=551250
==========

[Fady Samuel, 2015-11-28 21:46:08]

Description was changed from

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

BUG=551250
==========

to

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a
RenderWidgetMusConnection, and prior to notification of embedding in Mus
(RenderWidgetMusConnection::OnEmbed). This CL provides a mechanism to create a
WindowSurface prior to the availability of a Window. When creating a
WindowSurface, a sibling object, WindowSurfaceBinding is also created that can
be passed into Window::AttachSurface once a mus::Window is available.

BUG=551250
==========

[Fady Samuel, 2015-11-28 21:46:21]

Description was changed from

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a
RenderWidgetMusConnection, and prior to notification of embedding in Mus
(RenderWidgetMusConnection::OnEmbed). This CL provides a mechanism to create a
WindowSurface prior to the availability of a Window. When creating a
WindowSurface, a sibling object, WindowSurfaceBinding is also created that can
be passed into Window::AttachSurface once a mus::Window is available.

BUG=551250
==========

to

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a 
RenderWidgetMusConnection, and prior to notification of embedding in 
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a 
mechanism to create a WindowSurface prior to the availability of a 
Window. When creating a WindowSurface, a sibling object, 
WindowSurfaceBinding is also created that can be passed into 
Window::AttachSurface once a mus::Window is available.

BUG=551250
==========

[Fady Samuel, 2015-11-28 21:47:35]

fsamuel@chromium.org changed reviewers:
+ ben@chromium.org

[Fady Samuel, 2015-11-28 21:47:37]

+ben@ for OWNER review.

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/c...
File components/mus/public/cpp/window_surface.h (right):

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/c...
components/mus/public/cpp/window_surface.h:61: class WindowSurfaceBinding {
On 2015/11/27 21:21:37, sadrul wrote:
> Document

Done.

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/i...
File components/mus/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/1484533002/diff/60001/components/mus/public/i...
components/mus/public/interfaces/window_tree.mojom:118: // Attaches a Surface
for a particular window.
On 2015/11/27 21:21:37, sadrul wrote:
> *to

Done.

[Ben Goodger (Google), 2015-11-30 21:28:37]

lgtm

[Fady Samuel, 2015-11-30 21:49:55]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-11-30 21:49:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1484533002/#ps100001
(title: "Addressed Sadrul's comments")

[commit-bot: I haz the power, 2015-11-30 21:52:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484533002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484533002/100001

[commit-bot: I haz the power, 2015-11-30 23:44:38]

Description was changed from

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a 
RenderWidgetMusConnection, and prior to notification of embedding in 
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a 
mechanism to create a WindowSurface prior to the availability of a 
Window. When creating a WindowSurface, a sibling object, 
WindowSurfaceBinding is also created that can be passed into 
Window::AttachSurface once a mus::Window is available.

BUG=551250
==========

to

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a 
RenderWidgetMusConnection, and prior to notification of embedding in 
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a 
mechanism to create a WindowSurface prior to the availability of a 
Window. When creating a WindowSurface, a sibling object, 
WindowSurfaceBinding is also created that can be passed into 
Window::AttachSurface once a mus::Window is available.

BUG=551250
==========

[commit-bot: I haz the power, 2015-11-30 23:44:39]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-11-30 23:47:19]

Description was changed from

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a 
RenderWidgetMusConnection, and prior to notification of embedding in 
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a 
mechanism to create a WindowSurface prior to the availability of a 
Window. When creating a WindowSurface, a sibling object, 
WindowSurfaceBinding is also created that can be passed into 
Window::AttachSurface once a mus::Window is available.

BUG=551250
==========

to

==========
mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

RenderWidget::CreateOutputSurface is called prior to the availability of a
RenderWidgetMusConnection, and prior to notification of embedding in
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a
mechanism to create a WindowSurface prior to the availability of a
Window. When creating a WindowSurface, a sibling object,
WindowSurfaceBinding is also created that can be passed into
Window::AttachSurface once a mus::Window is available.

BUG=551250

Committed: https://crrev.com/e5c09bb427330401fc089989fccc16f9ea971664
Cr-Commit-Position: refs/heads/master@{#362273}
==========

[commit-bot: I haz the power, 2015-11-30 23:47:20]

Patchset 5 (id:??) landed as
https://crrev.com/e5c09bb427330401fc089989fccc16f9ea971664
Cr-Commit-Position: refs/heads/master@{#362273}