components/mus/public/interfaces/window_tree.mojom - Issue 1484533002: mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/interfaces/window_tree.mojom

Issue 1484533002: mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Sadrul's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/mus/public/interfaces/window_tree.mojom

diff --git a/components/mus/public/interfaces/window_tree.mojom b/components/mus/public/interfaces/window_tree.mojom

index ea172b3bfc179bc5b30ec24031513b026a685648..e0a27a0f27a9ff4b6869b7cd04d3ee97bb56e626 100644

--- a/components/mus/public/interfaces/window_tree.mojom

+++ b/components/mus/public/interfaces/window_tree.mojom

@@ -115,11 +115,11 @@ interface WindowTree {

string name,

array<uint8>? value);

- // Requests a Surface for a particular window.

- RequestSurface(uint32 window_id,

- SurfaceType type,

- Surface& surface,

- SurfaceClient client);

+ // Attaches a Surface to a particular window.

+ AttachSurface(uint32 window_id,

+ SurfaceType type,

+ Surface& surface,

+ SurfaceClient client);

// Reparents a window.

// This fails for any of the following reasons:

« no previous file with comments | « components/mus/public/cpp/window_surface.h ('k') | components/mus/ws/window_tree_impl.h » ('j') | no next file with comments »