Issue 14842011: Stop including main header twice in generated implementation code

Issue 14842011: Stop including main header twice in generated implementation code (Closed)

Created:
7 years, 7 months ago by do-not-use

Modified:
7 years, 7 months ago

Reviewers:
haraken, arv (Not doing code reviews), abarth-chromium

CC:
blink-reviews, haraken, Nate Chapin, eae+blinkwatch, jsbell+bindings_chromium.org, abarth-chromium, lgombos

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Stop including main header twice in generated implementation code The bindings generator were including the main header twice when generating implementation code. This causes the style script to complain. This patch makes sure the main header is included only once, right after "config.h". Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149976

Patch Set 1 #

Patch Set 2 : Rebase on master #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -15 lines)			Patch
M	Source/bindings/scripts/CodeGeneratorV8.pm	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8Float64Array.cpp	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestActiveDOMObject.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestCustomNamedGetter.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestEventConstructor.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestEventTarget.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestException.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestMediaQueryListListener.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestNamedConstructor.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestNode.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestOverloadedConstructors.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14842011/2001

7 years, 7 months ago (2013-05-08 19:56:21 UTC) #3

Message was sent while issue was closed.

Change committed as 149976

Expand Messages | Collapse Messages