Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14842011: Stop including main header twice in generated implementation code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8Float64Array.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index 6dd476178a94a259375aba4d6bbd5d5f78ebfa03..3d903081b7da5b91443bab9bc566e5101a03d707 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -440,6 +440,12 @@ sub AddIncludesForType
}
# additional includes (things needed to compile the bindings but not the header)
+ AddExtraIncludesForType($type);
+}
+
+sub AddExtraIncludesForType
+{
+ my $type = shift;
if ($type eq "CanvasRenderingContext2D") {
AddToImplIncludes("core/html/canvas/CanvasGradient.h");
@@ -3314,7 +3320,7 @@ sub GenerateImplementation
AddToImplIncludes("core/dom/ContextFeatures.h");
AddToImplIncludes("RuntimeEnabledFeatures.h");
- AddIncludesForType($interfaceName);
+ AddExtraIncludesForType($interfaceName);
my $toActiveDOMObject = InheritsExtendedAttribute($interface, "ActiveDOMObject") ? "${v8InterfaceName}::toActiveDOMObject" : "0";
my $toEventTarget = InheritsExtendedAttribute($interface, "EventTarget") ? "${v8InterfaceName}::toEventTarget" : "0";
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8Float64Array.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698