Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14842011: Stop including main header twice in generated implementation code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8Float64Array.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 AddToImplIncludes(GetV8HeaderName(${type})); 433 AddToImplIncludes(GetV8HeaderName(${type}));
434 434
435 if ($type =~ /SVGPathSeg/) { 435 if ($type =~ /SVGPathSeg/) {
436 my $joinedName = $type; 436 my $joinedName = $type;
437 $joinedName =~ s/Abs|Rel//; 437 $joinedName =~ s/Abs|Rel//;
438 AddToImplIncludes("core/svg/${joinedName}.h"); 438 AddToImplIncludes("core/svg/${joinedName}.h");
439 } 439 }
440 } 440 }
441 441
442 # additional includes (things needed to compile the bindings but not the hea der) 442 # additional includes (things needed to compile the bindings but not the hea der)
443 AddExtraIncludesForType($type);
444 }
445
446 sub AddExtraIncludesForType
447 {
448 my $type = shift;
443 449
444 if ($type eq "CanvasRenderingContext2D") { 450 if ($type eq "CanvasRenderingContext2D") {
445 AddToImplIncludes("core/html/canvas/CanvasGradient.h"); 451 AddToImplIncludes("core/html/canvas/CanvasGradient.h");
446 AddToImplIncludes("core/html/canvas/CanvasPattern.h"); 452 AddToImplIncludes("core/html/canvas/CanvasPattern.h");
447 AddToImplIncludes("core/html/canvas/CanvasStyle.h"); 453 AddToImplIncludes("core/html/canvas/CanvasStyle.h");
448 } 454 }
449 455
450 if ($type eq "CanvasGradient" or $type eq "XPathNSResolver") { 456 if ($type eq "CanvasGradient" or $type eq "XPathNSResolver") {
451 AddToImplIncludes("wtf/text/WTFString.h"); 457 AddToImplIncludes("wtf/text/WTFString.h");
452 } 458 }
(...skipping 2854 matching lines...) Expand 10 before | Expand all | Expand 10 after
3307 my $vtableRefWin = GetWinVTableRefForInterface($interface); 3313 my $vtableRefWin = GetWinVTableRefForInterface($interface);
3308 3314
3309 # - Add default header template 3315 # - Add default header template
3310 push(@implContentHeader, GenerateImplementationContentHeader($interface)); 3316 push(@implContentHeader, GenerateImplementationContentHeader($interface));
3311 3317
3312 AddToImplIncludes("bindings/v8/V8Binding.h"); 3318 AddToImplIncludes("bindings/v8/V8Binding.h");
3313 AddToImplIncludes("bindings/v8/V8DOMWrapper.h"); 3319 AddToImplIncludes("bindings/v8/V8DOMWrapper.h");
3314 AddToImplIncludes("core/dom/ContextFeatures.h"); 3320 AddToImplIncludes("core/dom/ContextFeatures.h");
3315 AddToImplIncludes("RuntimeEnabledFeatures.h"); 3321 AddToImplIncludes("RuntimeEnabledFeatures.h");
3316 3322
3317 AddIncludesForType($interfaceName); 3323 AddExtraIncludesForType($interfaceName);
3318 3324
3319 my $toActiveDOMObject = InheritsExtendedAttribute($interface, "ActiveDOMObje ct") ? "${v8InterfaceName}::toActiveDOMObject" : "0"; 3325 my $toActiveDOMObject = InheritsExtendedAttribute($interface, "ActiveDOMObje ct") ? "${v8InterfaceName}::toActiveDOMObject" : "0";
3320 my $toEventTarget = InheritsExtendedAttribute($interface, "EventTarget") ? " ${v8InterfaceName}::toEventTarget" : "0"; 3326 my $toEventTarget = InheritsExtendedAttribute($interface, "EventTarget") ? " ${v8InterfaceName}::toEventTarget" : "0";
3321 my $rootForGC = NeedsCustomOpaqueRootForGC($interface) ? "${v8InterfaceName} ::opaqueRootForGC" : "0"; 3327 my $rootForGC = NeedsCustomOpaqueRootForGC($interface) ? "${v8InterfaceName} ::opaqueRootForGC" : "0";
3322 3328
3323 # Find the super descriptor. 3329 # Find the super descriptor.
3324 my $parentClass = ""; 3330 my $parentClass = "";
3325 my $parentClassTemplate = ""; 3331 my $parentClassTemplate = "";
3326 foreach (@{$interface->parents}) { 3332 foreach (@{$interface->parents}) {
3327 my $parent = $_; 3333 my $parent = $_;
(...skipping 2357 matching lines...) Expand 10 before | Expand all | Expand 10 after
5685 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 5691 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
5686 $found = 1; 5692 $found = 1;
5687 } 5693 }
5688 return 1 if $found; 5694 return 1 if $found;
5689 }, 0); 5695 }, 0);
5690 5696
5691 return $found; 5697 return $found;
5692 } 5698 }
5693 5699
5694 1; 5700 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8Float64Array.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698