chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per review comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_controller_impl.h ('K') | « chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('k') | components/autofill/content/browser/autofill_driver_impl.h » ('j') | components/autofill/content/browser/autofill_driver_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

index d0c77e299399aeae66264e9300d3a24e70d1d05b..b4ab5a8ef71efe161070b0e12c1fbe5cf6beb286 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

@@ -44,7 +44,8 @@ class MockAutofillExternalDelegate : public AutofillExternalDelegate {

: AutofillExternalDelegate(autofill_manager, autofill_driver) {}

virtual ~MockAutofillExternalDelegate() {}

- virtual void DidSelectSuggestion(int identifier) OVERRIDE {}

+ virtual void DidSelectSuggestion(int identifier,

+ const base::string16& value) OVERRIDE {}

virtual void RemoveSuggestion(const base::string16& value,

int identifier) OVERRIDE {}

virtual void ClearPreviewedForm() OVERRIDE {}