chrome/browser/ui/autofill/autofill_dialog_controller_impl.h - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per review comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | components/autofill/content/browser/autofill_driver_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

index 97434021ea97cb291f811aae063950e930b3637e..a14a7963a5dd4f87a486b3f33f7e2de6c35587a4 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

@@ -165,7 +165,8 @@ class AutofillDialogControllerImpl

virtual void OnPopupShown() OVERRIDE;

virtual void OnPopupHidden() OVERRIDE;

virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;

- virtual void DidSelectSuggestion(int identifier) OVERRIDE;

+ virtual void DidSelectSuggestion(int identifier,

+ const base::string16& value) OVERRIDE;

Ilya Sherman 2014/02/22 05:59:51 nit: Please update the parameters to have the same

ziran.sun 2014/02/27 15:38:11 Done.

virtual void DidAcceptSuggestion(const base::string16& value,

int identifier) OVERRIDE;

virtual void RemoveSuggestion(const base::string16& value,

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | components/autofill/content/browser/autofill_driver_impl.h » ('J')