chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per review comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_controller_impl.h ('K') | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc » ('j') | components/autofill/content/browser/autofill_driver_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index 9d7fae9677fdb33a8c5db2dca4f8baa0376198b1..06ea0a9e69c853c75e8073cee63651e6f71371a1 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -444,10 +444,12 @@ void AutofillPopupControllerImpl::SetSelectedLine(int selected_line) {

selected_line_ = selected_line;

- if (selected_line_ != kNoSelection)

- delegate_->DidSelectSuggestion(identifiers_[selected_line_]);

- else

+ if (selected_line_ != kNoSelection) {

+ delegate_->DidSelectSuggestion(identifiers_[selected_line_],

+ names_[selected_line_]);

+ } else {

delegate_->ClearPreviewedForm();

+ }

}

void AutofillPopupControllerImpl::SelectNextLine() {