Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/extensions/extension_fullscreen_apitest.cc

Issue 1483893002: Various fixes for ExtensionApiTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 #include "chrome/browser/ui/browser_window.h" 6 #include "chrome/browser/ui/browser_window.h"
7 7
8 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, 8 IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
9 ExtensionFullscreenAccessFail) { 9 ExtensionFullscreenAccessFail) {
10 // Test that fullscreen cannot be accessed from an extension without 10 // Test that fullscreen cannot be accessed from an extension without
(...skipping 11 matching lines...) Expand all
22 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_ExtensionFullscreenAccessPass) { 22 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_ExtensionFullscreenAccessPass) {
23 // Test that fullscreen can be accessed from an extension with permission. 23 // Test that fullscreen can be accessed from an extension with permission.
24 ASSERT_TRUE(RunPlatformAppTest("fullscreen/has_permission")) << message_; 24 ASSERT_TRUE(RunPlatformAppTest("fullscreen/has_permission")) << message_;
25 } 25 }
26 26
27 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, 27 IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
28 FocusWindowDoesNotExitFullscreen) { 28 FocusWindowDoesNotExitFullscreen) {
29 browser()->window()->EnterFullscreen( 29 browser()->window()->EnterFullscreen(
30 GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION, 30 GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION,
31 false); 31 false);
32 bool is_fullscreen = browser()->window()->IsFullscreen(); 32 ASSERT_TRUE(browser()->window()->IsFullscreen());
33 ASSERT_TRUE(RunExtensionTest("window_update/focus")) << message_; 33 ASSERT_TRUE(RunExtensionTest("window_update/focus")) << message_;
34 ASSERT_EQ(is_fullscreen, browser()->window()->IsFullscreen()); 34 ASSERT_TRUE(browser()->window()->IsFullscreen());
35 } 35 }
36 36
37 // Fails flakily: http://crbug.com/308041 37 #if defined(OS_MACOSX)
38 // Fails flakily on Mac: http://crbug.com/308041
39 #define MAYBE_UpdateWindowSizeExitsFullscreen \
40 DISABLED_UpdateWindowSizeExitsFullscreen
41 #else
42 #define MAYBE_UpdateWindowSizeExitsFullscreen UpdateWindowSizeExitsFullscreen
43 #endif // defined(OS_MACOSX)
38 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, 44 IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
39 DISABLED_UpdateWindowSizeExitsFullscreen) { 45 MAYBE_UpdateWindowSizeExitsFullscreen) {
40 browser()->window()->EnterFullscreen( 46 browser()->window()->EnterFullscreen(
41 GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION, 47 GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION,
42 false); 48 false);
43 ASSERT_TRUE(RunExtensionTest("window_update/sizing")) << message_; 49 ASSERT_TRUE(RunExtensionTest("window_update/sizing")) << message_;
44 ASSERT_FALSE(browser()->window()->IsFullscreen()); 50 ASSERT_FALSE(browser()->window()->IsFullscreen());
45 } 51 }
46 52
47 #if defined(OS_MACOSX) 53 #if defined(OS_MACOSX)
48 // Fails on MAC: http://crbug.com/480370 54 // Fails on MAC: http://crbug.com/480370
49 #define MAYBE_DisplayModeWindowIsInFullscreen DISABLED_DisplayModeWindowIsInFull screen 55 #define MAYBE_DisplayModeWindowIsInFullscreen DISABLED_DisplayModeWindowIsInFull screen
50 #else 56 #else
51 #define MAYBE_DisplayModeWindowIsInFullscreen DisplayModeWindowIsInFullscreen 57 #define MAYBE_DisplayModeWindowIsInFullscreen DisplayModeWindowIsInFullscreen
52 #endif // defined(OS_MACOSX) 58 #endif // defined(OS_MACOSX)
53 59
54 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, 60 IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
55 MAYBE_DisplayModeWindowIsInFullscreen) { 61 MAYBE_DisplayModeWindowIsInFullscreen) {
56 ASSERT_TRUE(RunPlatformAppTest("fullscreen/mq_display_mode")) << message_; 62 ASSERT_TRUE(RunPlatformAppTest("fullscreen/mq_display_mode")) << message_;
57 } 63 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698