Issue 148353002: Add support of Pause/Resume for polling thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148353002: Add support of Pause/Resume for polling thread

Created:
6 years, 11 months ago by SaurabhK

Modified:
6 years, 10 months ago

Reviewers:
Tom Sepez, darin (slow to review), scottmg, xwang

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add support of Pause/Resume for polling thread This change adds the support of pause/resume of poll thread in the NavigatorGamepad class. This way polling thread only runs whenever gamepad data is accessed by the webpage. While in the case of gamepad data release (Browser minimize and Tab switch) poll thread can be put to paused state. BUG=330094 TEST=http://www.html5rocks.com/en/tutorials/doodles/gamepad/gamepad-tester/tester.html R=tsepez@chromium.org R=darin@chromium.org R=scottmg@chromium.org R=xingnan.wang@chromium.org

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	Source/modules/gamepad/NavigatorGamepad.cpp	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download
	M	public/platform/Platform.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

scottmg

6 years, 10 months ago (2014-02-06 20:46:23 UTC) #1

https://codereview.chromium.org/148353002/diff/30001/Source/modules/gamepad/N...
File Source/modules/gamepad/NavigatorGamepad.cpp (right):

https://codereview.chromium.org/148353002/diff/30001/Source/modules/gamepad/N...
Source/modules/gamepad/NavigatorGamepad.cpp:67:
blink::Platform::current()->pauseGamepads();
I don't think the renderer should be telling the browser when to do this. If the
renderer crashes, then these will be unbalanced.

Expand Messages | Collapse Messages