Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1483313002: go generator: generate full identifiers (Closed)

Created:
5 years ago by bprosnitz
Modified:
5 years ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

go generator: generate full identifiers In the current generator, only ShortNames are outputted for declarations, but this results in a loss of information because the pacakge path cannot be recovered. BUG= R=alexfandrianto@google.com, rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1608780b78ac467dcbf1761ebc0359739c3c6bbd

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -14 lines) Patch
M mojo/go/tests/validation_type_test.go View 1 2 3 12 chunks +47 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl View 1 2 9 chunks +9 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_go_generator.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
bprosnitz
5 years ago (2015-12-01 09:11:45 UTC) #2
bprosnitz
5 years ago (2015-12-02 08:28:14 UTC) #3
alexfandrianto
On 2015/12/02 08:28:14, bprosnitz wrote: I don't know if I'm allowed to do this, but... ...
5 years ago (2015-12-02 18:37:41 UTC) #4
bprosnitz
5 years ago (2015-12-03 02:58:40 UTC) #6
bprosnitz
On 2015/12/03 02:58:40, bprosnitz wrote: I'm not sure who can submit this
5 years ago (2015-12-03 03:05:13 UTC) #7
bprosnitz
5 years ago (2015-12-03 03:24:10 UTC) #9
rudominer
On 2015/12/03 03:05:13, bprosnitz wrote: > On 2015/12/03 02:58:40, bprosnitz wrote: > > I'm not ...
5 years ago (2015-12-03 17:54:28 UTC) #10
bprosnitz
5 years ago (2015-12-04 03:12:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:50001) manually as
1608780b78ac467dcbf1761ebc0359739c3c6bbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698