Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: mojo/public/tools/bindings/generators/mojom_go_generator.py

Issue 1483313002: go generator: generate full identifiers (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/mojom_go_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_go_generator.py b/mojo/public/tools/bindings/generators/mojom_go_generator.py
index e9b6bfb9735de334c6ac5d52fe6ea575675654ad..c62ac2968423a560891c7d9704fd7e67edff101d 100644
--- a/mojo/public/tools/bindings/generators/mojom_go_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_go_generator.py
@@ -142,7 +142,12 @@ def FormatName(name, exported=True):
# |FormatName()| calls only.
def GetFullName(element, exported=True):
return GetQualifiedName(
- element.name, GetPackageNameForElement(element), exported)
+ element.name, GetPackageNameForElement(element), exported)
+
+# Returns a string of the form package.path.TypeName - the full identifier
+# for an element.
+def GetFullIdentifier(element, exported=True):
+ return '%s.%s' % (element.module.namespace, GetNameForElement(element))
def GetUnqualifiedNameForElement(element, exported=True):
return FormatName(element.name, exported)
@@ -357,6 +362,7 @@ class Generator(generator.Generator):
'is_struct': mojom.IsStructKind,
'is_union': mojom.IsUnionKind,
'qualified': GetQualifiedName,
+ 'fullidentifier': GetFullIdentifier,
'mojom_type': GetMojomTypeValue,
'mojom_type_identifier': GetMojomTypeIdentifier,
'name': GetNameForElement,
« no previous file with comments | « mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698