Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl

Issue 1483313002: go generator: generate full identifiers (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/go/tests/validation_type_test.go ('k') | mojo/public/tools/bindings/generators/mojom_go_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl
diff --git a/mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl b/mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl
index bad74532586bb8730a58baa0c47e222da16cd1e5..e6ba23da2fe6689d514c234263791961b67a96aa 100644
--- a/mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl
+++ b/mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl
@@ -68,6 +68,7 @@
// String names and labels used by the MojomEnum types.
var (
enumName_{{type|name}} = "{{type|name}}"
+ enumFullIdentifier_{{type|name}} = "{{type|fullidentifier}}"
{% for field in type.fields %}
enumFieldName_{{type|name}}_{{field|name}} = "{{field|name}}"
{% endfor %}
@@ -80,6 +81,7 @@ func {{type|mojom_type_identifier}}() {{typepkg}}MojomEnum {
// String names and labels used by the MojomStruct types.
var (
structName_{{type|name}} = "{{type|name}}"
+ structFullIdentifier_{{type|name}} = "{{type|fullidentifier}}"
{% for field in type.fields %}
structFieldName_{{type|name}}_{{field|name}} = "{{field|name}}"
{% endfor %}
@@ -92,6 +94,7 @@ func {{type|mojom_type_identifier}}() {{typepkg}}MojomStruct {
// String names and labels used by the MojomUnion types.
var (
unionName_{{type|name}} = "{{type|name}}"
+ unionFullIdentifier_{{type|name}} = "{{type|fullidentifier}}"
{% for field in type.fields %}
unionFieldName_{{type|name}}_{{field|name}} = "{{field|name}}"
{% endfor %}
@@ -103,6 +106,7 @@ func {{type|mojom_type_identifier}}() {{typepkg}}MojomUnion {
{%- elif type|is_interface -%}
var (
interfaceName_{{type|name}} = "{{type|name}}"
+ interfaceFullIdentifier_{{type|name}} = "{{type|fullidentifier}}"
{% for method in type.methods %}
interfaceMethodName_{{type|name}}_{{method|name}} = "{{method|name}}"
{% endfor %}
@@ -120,6 +124,7 @@ func {{type|mojom_type_identifier}}() {{typepkg}}MojomInterface {
return {{typepkg}}MojomInterface{
DeclData: &{{typepkg}}DeclarationData{
ShortName: &interfaceName_{{type|name}},
+ FullIdentifier: &interfaceFullIdentifier_{{type|name}},
},
Methods: map[uint32]{{typepkg}}MojomMethod{
{%- for method in type.methods -%}
@@ -170,6 +175,7 @@ BAD TYPE NAME GIVEN
{{typepkg}}MojomEnum{
DeclData: &{{typepkg}}DeclarationData{
ShortName: &enumName_{{type|name}},
+ FullIdentifier: &enumFullIdentifier_{{type|name}},
},
Values: []{{typepkg}}EnumValue{
{%- for field in type.fields -%}
@@ -190,6 +196,7 @@ BAD TYPE NAME GIVEN
{{typepkg}}MojomStruct{
DeclData: &{{typepkg}}DeclarationData{
ShortName: &structName_{{type|name}},
+ FullIdentifier: &structFullIdentifier_{{type|name}},
},
{%- if type|is_nullable -%}
Nullable: true,
@@ -212,6 +219,7 @@ BAD TYPE NAME GIVEN
{{typepkg}}MojomUnion{
DeclData: &{{typepkg}}DeclarationData{
ShortName: &unionName_{{type|name}},
+ FullIdentifier: &unionFullIdentifier_{{type|name}},
},
{%- if type|is_nullable -%}
Nullable: true,
@@ -228,4 +236,4 @@ BAD TYPE NAME GIVEN
{%- endfor -%}
},
}
-{%- endmacro -%}
+{%- endmacro -%}
« no previous file with comments | « mojo/go/tests/validation_type_test.go ('k') | mojo/public/tools/bindings/generators/mojom_go_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698