Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 14831004: Introduce architecture specific headers describing Dart stack frames. (Closed)

Created:
7 years, 7 months ago by regis
Modified:
7 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Introduce architecture specific headers describing Dart stack frames. The actual cleanup will follow in another cl. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22394

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -125 lines) Patch
M runtime/vm/constants_arm.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/constants_ia32.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
M runtime/vm/constants_x64.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/locations.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/scopes.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/stack_frame.h View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
A runtime/vm/stack_frame_arm.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A runtime/vm/stack_frame_ia32.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A runtime/vm/stack_frame_mips.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A runtime/vm/stack_frame_x64.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 15 chunks +34 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
This is purely mechanical, including the alphabetical sorting of files in vm_sources.gypi.
7 years, 7 months ago (2013-05-03 21:03:30 UTC) #1
siva
lgtm
7 years, 7 months ago (2013-05-03 21:33:21 UTC) #2
regis
Thanks!
7 years, 7 months ago (2013-05-03 21:40:06 UTC) #3
regis
7 years, 7 months ago (2013-05-03 21:42:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r22394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698