runtime/vm/constants_x64.h - Issue 14831004: Introduce architecture specific headers describing Dart stack frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_x64.h

Issue 14831004: Introduce architecture specific headers describing Dart stack frames. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/constants_x64.h

===================================================================

--- runtime/vm/constants_x64.h (revision 22393)

+++ runtime/vm/constants_x64.h (working copy)

@@ -99,29 +99,6 @@

const Register kStackTraceObjectReg = RDX;

-// TODO(regis): Move these constants to stack_frame_x64.h.

-// Dart stack frame layout.

-static const int kLastParamSlotIndex = 2; // From fp.

-static const int kFirstLocalSlotIndex = -2; // From fp.

-static const int kPcSlotIndexFromSp = -1;

-/* X64 Dart Frame Layout

- | | <- TOS

-Callee frame | ... |

- | current ret addr | (PC of current frame)

- +-------------------+

-Current frame | ... | <- RSP of current frame

- | first local |

- | PC Marker | (current frame's code entry)

- | caller's RBP | <- RBP of current frame

- | caller's ret addr | (PC of caller frame)

- +-------------------+

-Caller frame | last parameter |

- | ... |

-*/

enum ScaleFactor {

TIMES_1 = 0,

TIMES_2 = 1,

« no previous file with comments | « runtime/vm/constants_mips.h ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »