Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: runtime/vm/constants_arm.h

Issue 14831004: Introduce architecture specific headers describing Dart stack frames. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/constants_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_arm.h
===================================================================
--- runtime/vm/constants_arm.h (revision 22393)
+++ runtime/vm/constants_arm.h (working copy)
@@ -182,30 +182,6 @@
const int kDartVolatileFpuRegCount = 8;
-// TODO(regis): Move these constants to stack_frame_arm.h.
-// Dart stack frame layout.
-static const int kLastParamSlotIndex = 3; // From fp.
-static const int kFirstLocalSlotIndex = -2; // From fp.
-static const int kPcSlotIndexFromSp = -2;
-
-/* ARM Dart Frame Layout
-
- | | <- TOS
-Callee frame | ... |
- | current LR | (PC of current frame)
- | PC Marker | (callee's frame code entry)
- +-------------------+
-Current frame | ... | <- SP of current frame
- | first local |
- | caller's PP |
- | caller's FP | <- FP of current frame
- | caller's LR | (PC of caller frame)
- | PC Marker | (current frame's code entry)
- +-------------------+
-Caller frame | last parameter |
- | ... |
-*/
-
// Values for the condition field as defined in section A3.2.
enum Condition {
kNoCondition = -1,
« no previous file with comments | « no previous file | runtime/vm/constants_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698