Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 148273008: SaveCallerSaveRegsisters needs to save all caller-save registers (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

SaveCallerSaveRegsisters needs to save all caller-save registers While the macro assembler uses them as scratch registers, we need to save them when calling out to builtins. In debug mode, the simulator will clobber all registers after a call to a builtin which makes regress-119926.js crash. BUG=none R=rodolph.perfetta@arm.com, ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18879

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/a64/code-stubs-a64.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-28 12:36:54 UTC) #1
jochen (gone - plz use gerrit)
ptal
6 years, 10 months ago (2014-01-28 12:47:00 UTC) #2
ulan
lgtm
6 years, 10 months ago (2014-01-28 13:11:48 UTC) #3
Rodolph Perfetta (ARM)
Nice catch. x8 and x9 used to be temp in the macro assembler. Not anymore. ...
6 years, 10 months ago (2014-01-28 13:24:57 UTC) #4
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-28 13:29:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r18879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698