Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/a64/code-stubs-a64.h

Issue 148273008: SaveCallerSaveRegsisters needs to save all caller-save registers (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: spelling Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/code-stubs-a64.h
diff --git a/src/a64/code-stubs-a64.h b/src/a64/code-stubs-a64.h
index 4094887aaf69b03f9a68b06b406fe277f6634c2f..dfdc5fccf2555121757f1c1f44a7f8490e1cd718 100644
--- a/src/a64/code-stubs-a64.h
+++ b/src/a64/code-stubs-a64.h
@@ -304,7 +304,7 @@ class RecordWriteStub: public PlatformCodeStub {
saved_regs_(kCallerSaved) {
ASSERT(!AreAliased(scratch, object, address));
- // We would like to requiere more scratch registers for this stub,
+ // We would like to require more scratch registers for this stub,
// but the number of registers comes down to the ones used in
// FullCodeGen::SetVar(), which is architecture independent.
// We allocate 2 extra scratch registers that we'll save on the stack.
@@ -315,12 +315,10 @@ class RecordWriteStub: public PlatformCodeStub {
scratch2_ = Register(pool_available.PopLowestIndex());
// SaveCallerRegisters method needs to save caller saved register, however
- // we dont bother saving x8, x9, ip0 and ip1 because they are used as
- // scratch registers by the MacroAssembler.
+ // we don't bother saving ip0 and ip1 because they are used as scratch
+ // registers by the MacroAssembler.
saved_regs_.Remove(ip0);
saved_regs_.Remove(ip1);
- saved_regs_.Remove(x8);
- saved_regs_.Remove(x9);
// The scratch registers will be restored by other means so we don't need
// to save them with the other caller saved registers.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698