Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 14821005: [RFP, Autofill] Switching dialog field identification to int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 0c7532a91c794a0846ac293738187788634885bc..452779b57a966d2a27a6cb7cfa32b5c71b74a93c 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -54,7 +54,7 @@ class TestAutofillDialogView : public AutofillDialogView {
virtual void UpdateButtonStrip() OVERRIDE {}
virtual void UpdateSection(DialogSection section) OVERRIDE {}
virtual void FillSection(DialogSection section,
- const DetailInput& originating_input) OVERRIDE {};
+ AutofillFieldType originating_input) OVERRIDE {}
virtual void GetUserInput(DialogSection section, DetailOutputMap* output)
OVERRIDE {
*output = outputs_[section];
@@ -269,7 +269,7 @@ class AutofillDialogControllerTest : public testing::Test {
const DetailInputs& cc_inputs =
controller()->RequestedFieldsForSection(SECTION_CC);
for (size_t i = 0; i < cc_inputs.size(); ++i) {
- cc_outputs[&cc_inputs[i]] = ASCIIToUTF16("11");
+ cc_outputs[cc_inputs[i].type] = ASCIIToUTF16("11");
}
controller()->GetView()->SetUserInput(SECTION_CC, cc_outputs);
}
@@ -531,8 +531,8 @@ TEST_F(AutofillDialogControllerTest, EditAutofillProfile) {
controller()->RequestedFieldsForSection(SECTION_SHIPPING);
for (size_t i = 0; i < inputs.size(); ++i) {
const DetailInput& input = inputs[i];
- outputs[&input] = input.type == NAME_FULL ? ASCIIToUTF16("Edited Name") :
- input.initial_value;
+ outputs[input.type] = input.type == NAME_FULL ? ASCIIToUTF16("Edited Name")
+ : input.initial_value;
}
controller()->GetView()->SetUserInput(SECTION_SHIPPING, outputs);
@@ -569,7 +569,7 @@ TEST_F(AutofillDialogControllerTest, AddAutofillProfile) {
AutofillProfile full_profile2(test::GetFullProfile2());
for (size_t i = 0; i < inputs.size(); ++i) {
const DetailInput& input = inputs[i];
- outputs[&input] = full_profile2.GetInfo(input.type, "en-US");
+ outputs[input.type] = full_profile2.GetInfo(input.type, "en-US");
}
controller()->GetView()->SetUserInput(SECTION_BILLING, outputs);
@@ -579,8 +579,9 @@ TEST_F(AutofillDialogControllerTest, AddAutofillProfile) {
const DetailInputs& cc_inputs =
controller()->RequestedFieldsForSection(SECTION_CC);
for (size_t i = 0; i < cc_inputs.size(); ++i) {
- cc_outputs[&cc_inputs[i]] = cc_inputs[i].type == CREDIT_CARD_NAME ?
- ASCIIToUTF16("Bill Money") : ASCIIToUTF16("111");
+ cc_outputs[cc_inputs[i].type] =
+ cc_inputs[i].type == CREDIT_CARD_NAME ? ASCIIToUTF16("Bill Money")
+ : ASCIIToUTF16("111");
}
controller()->GetView()->SetUserInput(SECTION_CC, cc_outputs);
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698