Issue 14820035: Re-add isIRect test for AA rect drawing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14820035: Re-add isIRect test for AA rect drawing (Closed)

Created:
7 years, 7 months ago by robertphillips

Modified:
7 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

"Reverting" r9087 (Remove isIRect "optimization" & defer computation of device Rect in AA rect rendering) due to performance regressions on fireflies and spaceport io's partially cleared aligned translation test.

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -10 lines)			Patch
M	include/gpu/GrAARectRenderer.h	View	4 chunks	+4 lines, -1 line	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	5 chunks	+9 lines, -2 lines	2 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	4 chunks	+16 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/14820035/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/14820035/diff/1/src/gpu/GrAARectRenderer.cpp#newcode393 src/gpu/GrAARectRenderer.cpp:393: #if 0 Maybe a comment here (and below) ...

7 years, 7 months ago (2013-05-14 19:36:27 UTC) #2

robertphillips

committed as r9128 https://codereview.chromium.org/14820035/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/14820035/diff/1/src/gpu/GrAARectRenderer.cpp#newcode393 src/gpu/GrAARectRenderer.cpp:393: #if 0 On 2013/05/14 19:36:27, bsalomon ...

7 years, 7 months ago (2013-05-14 19:48:05 UTC) #3

Message was sent while issue was closed.

committed as r9128

Expand Messages | Collapse Messages