Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2869)

Unified Diff: chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc b/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
index f5ec945fd106201ce358ccf3cc6e5e7b97f33394..042563937ed827a35538cfa7cf9b17c007a88d40 100644
--- a/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
@@ -26,12 +26,15 @@ PasswordGenerationPopupViewAndroid::PasswordGenerationPopupViewAndroid(
: controller_(controller) {}
void PasswordGenerationPopupViewAndroid::SavedPasswordsLinkClicked(
- JNIEnv* env, jobject obj) {
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
if (controller_)
controller_->OnSavedPasswordsLinkClicked();
}
-void PasswordGenerationPopupViewAndroid::Dismissed(JNIEnv* env, jobject obj) {
+void PasswordGenerationPopupViewAndroid::Dismissed(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
if (controller_)
controller_->ViewDestroyed();
@@ -39,7 +42,8 @@ void PasswordGenerationPopupViewAndroid::Dismissed(JNIEnv* env, jobject obj) {
}
void PasswordGenerationPopupViewAndroid::PasswordSelected(
- JNIEnv* env, jobject object) {
+ JNIEnv* env,
+ const JavaParamRef<jobject>& object) {
if (controller_)
controller_->PasswordAccepted();
}

Powered by Google App Engine
This is Rietveld 408576698