Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/autofill/password_generation_popup_view_andr oid.h" 5 #include "chrome/browser/ui/android/autofill/password_generation_popup_view_andr oid.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
11 #include "base/android/scoped_java_ref.h" 11 #include "base/android/scoped_java_ref.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "chrome/browser/ui/android/window_android_helper.h" 13 #include "chrome/browser/ui/android/window_android_helper.h"
14 #include "chrome/browser/ui/autofill/password_generation_popup_controller.h" 14 #include "chrome/browser/ui/autofill/password_generation_popup_controller.h"
15 #include "content/public/browser/android/content_view_core.h" 15 #include "content/public/browser/android/content_view_core.h"
16 #include "jni/PasswordGenerationPopupBridge_jni.h" 16 #include "jni/PasswordGenerationPopupBridge_jni.h"
17 #include "ui/android/view_android.h" 17 #include "ui/android/view_android.h"
18 #include "ui/android/window_android.h" 18 #include "ui/android/window_android.h"
19 #include "ui/gfx/geometry/rect_f.h" 19 #include "ui/gfx/geometry/rect_f.h"
20 #include "ui/gfx/range/range.h" 20 #include "ui/gfx/range/range.h"
21 21
22 namespace autofill { 22 namespace autofill {
23 23
24 PasswordGenerationPopupViewAndroid::PasswordGenerationPopupViewAndroid( 24 PasswordGenerationPopupViewAndroid::PasswordGenerationPopupViewAndroid(
25 PasswordGenerationPopupController* controller) 25 PasswordGenerationPopupController* controller)
26 : controller_(controller) {} 26 : controller_(controller) {}
27 27
28 void PasswordGenerationPopupViewAndroid::SavedPasswordsLinkClicked( 28 void PasswordGenerationPopupViewAndroid::SavedPasswordsLinkClicked(
29 JNIEnv* env, jobject obj) { 29 JNIEnv* env,
30 const JavaParamRef<jobject>& obj) {
30 if (controller_) 31 if (controller_)
31 controller_->OnSavedPasswordsLinkClicked(); 32 controller_->OnSavedPasswordsLinkClicked();
32 } 33 }
33 34
34 void PasswordGenerationPopupViewAndroid::Dismissed(JNIEnv* env, jobject obj) { 35 void PasswordGenerationPopupViewAndroid::Dismissed(
36 JNIEnv* env,
37 const JavaParamRef<jobject>& obj) {
35 if (controller_) 38 if (controller_)
36 controller_->ViewDestroyed(); 39 controller_->ViewDestroyed();
37 40
38 delete this; 41 delete this;
39 } 42 }
40 43
41 void PasswordGenerationPopupViewAndroid::PasswordSelected( 44 void PasswordGenerationPopupViewAndroid::PasswordSelected(
42 JNIEnv* env, jobject object) { 45 JNIEnv* env,
46 const JavaParamRef<jobject>& object) {
43 if (controller_) 47 if (controller_)
44 controller_->PasswordAccepted(); 48 controller_->PasswordAccepted();
45 } 49 }
46 50
47 // static 51 // static
48 bool PasswordGenerationPopupViewAndroid::Register(JNIEnv* env) { 52 bool PasswordGenerationPopupViewAndroid::Register(JNIEnv* env) {
49 return RegisterNativesImpl(env); 53 return RegisterNativesImpl(env);
50 } 54 }
51 55
52 PasswordGenerationPopupViewAndroid::~PasswordGenerationPopupViewAndroid() {} 56 PasswordGenerationPopupViewAndroid::~PasswordGenerationPopupViewAndroid() {}
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 return false; 118 return false;
115 } 119 }
116 120
117 // static 121 // static
118 PasswordGenerationPopupView* PasswordGenerationPopupView::Create( 122 PasswordGenerationPopupView* PasswordGenerationPopupView::Create(
119 PasswordGenerationPopupController* controller) { 123 PasswordGenerationPopupController* controller) {
120 return new PasswordGenerationPopupViewAndroid(controller); 124 return new PasswordGenerationPopupViewAndroid(controller);
121 } 125 }
122 126
123 } // namespace autofill 127 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698