chrome/browser/ui/android/autofill/password_generation_popup_view_android.h - Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/password_generation_popup_view_android.h

Issue 1481553002: jni: Pass method parameters as JavaParamRef in chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc ('k') | chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/password_generation_popup_view_android.h

diff --git a/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h b/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h

index 806efa4829bfde7b6beb888e1753782062277f66..27f4ce87117e400062bdc6cb842295b7e68d9579 100644

--- a/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h

+++ b/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h

@@ -23,13 +23,16 @@ class PasswordGenerationPopupViewAndroid : public PasswordGenerationPopupView {

PasswordGenerationPopupController* controller);

// Called from JNI when the "saved passwords" link was clicked.

- void SavedPasswordsLinkClicked(JNIEnv* env, jobject obj);

+ void SavedPasswordsLinkClicked(

+ JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

// Called from JNI when the popup was dismissed.

- void Dismissed(JNIEnv* env, jobject obj);

+ void Dismissed(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

// Called from JNI when the suggested password was selected.

- void PasswordSelected(JNIEnv* env, jobject object);

+ void PasswordSelected(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& object);

// Registers the popup with JNI.

static bool Register(JNIEnv* env);