Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1481483002: Fix crash in ObjectPainter::paintOutline in flipped blocks (Closed)

Created:
5 years ago by kojii
Modified:
5 years ago
Reviewers:
wkorman, eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in ObjectPainter::paintOutline in flipped blocks This patch fixes an out-of-bounds access to a Vector, when the CSS outline property is applied to an inline element in flipped blocks writing mode. crbug.com/491454 fixed the positioning of the outline in the case, but it did not properly handle when non-empty outline becomes empty by the transform. BUG=561053, 491454 Committed: https://crrev.com/5c70b66b1b9b5488460c8c048ff7c32542d4c36f Cr-Commit-Position: refs/heads/master@{#361790}

Patch Set 1 #

Total comments: 6

Patch Set 2 : wkorman review #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
kojii
PTAL.
5 years ago (2015-11-25 03:57:45 UTC) #4
wkorman
https://codereview.chromium.org/1481483002/diff/1/third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html File third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html (right): https://codereview.chromium.org/1481483002/diff/1/third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html#newcode1 third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html:1: <style> <!DOCTYPE html> at top? https://codereview.chromium.org/1481483002/diff/1/third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html#newcode3 third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html:3: margin-top: inherit; ...
5 years ago (2015-11-25 07:02:45 UTC) #5
kojii
PTAL, thank you for reviewing this so promptly. https://codereview.chromium.org/1481483002/diff/1/third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html File third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html (right): https://codereview.chromium.org/1481483002/diff/1/third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html#newcode1 third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html:1: <style> ...
5 years ago (2015-11-25 07:23:23 UTC) #6
wkorman
lgtm
5 years ago (2015-11-25 07:24:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481483002/40001
5 years ago (2015-11-26 01:04:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/122488)
5 years ago (2015-11-26 01:17:20 UTC) #12
kojii
eae@, PTAL.
5 years ago (2015-11-26 01:25:16 UTC) #13
eae
LGTM
5 years ago (2015-11-26 01:26:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481483002/40001
5 years ago (2015-11-26 02:03:43 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-26 02:10:14 UTC) #18
commit-bot: I haz the power
5 years ago (2015-11-26 02:11:21 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5c70b66b1b9b5488460c8c048ff7c32542d4c36f
Cr-Commit-Position: refs/heads/master@{#361790}

Powered by Google App Engine
This is Rietveld 408576698