third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html - Issue 1481483002: Fix crash in ObjectPainter::paintOutline in flipped blocks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash.html

Issue 1481483002: Fix crash in ObjectPainter::paintOutline in flipped blocks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <style>
	wkorman 2015/11/25 07:02:44 <!DOCTYPE html> at top? <!DOCTYPE html> at top? kojii 2015/11/25 07:23:23 Done. Show quoted text On 2015/11/25 07:02:44, wkorman wrote: > <!DOCTYPE html> at top? Done.
	2 * {

	3 margin-top: inherit;
	wkorman 2015/11/25 07:02:44 4-indent here and rest of indentation below 4-indent here and rest of indentation below kojii 2015/11/25 07:23:23 Done. Looks like we prefer 2 for layout tests thes Show quoted text On 2015/11/25 07:02:44, wkorman wrote: > 4-indent here and rest of indentation below Done. Looks like we prefer 2 for layout tests these days but either seems to be fine. http://www.chromium.org/developers/coding-style#TOC-Web-languages-JavaScript-...
	4 border-top-style: dashed;

	5 }

	6

	7 *:only-of-type {

	8 outline-style: dotted;

	9 -webkit-writing-mode: vertical-rl;

	10 }

	11 </style>

	12 <svg>

	13 <text class="CLASS0 CLASS4" font-variant="small-caps"</metadata>
	wkorman 2015/11/25 07:02:44 Does the test require the strange tags (unclosed t Does the test require the strange tags (unclosed text, ending metadata without a begin tag, textPath below), and the margin-top and border-top-style above? clusterfuzz is so crazy. We should add a comment or text re: "this test passes if it does not crash." kojii 2015/11/25 07:23:23 Done. Since we have been having a code to remove Show quoted text On 2015/11/25 07:02:44, wkorman wrote: > Does the test require the strange tags (unclosed text, ending metadata without a > begin tag, textPath below), and the margin-top and border-top-style above? > > clusterfuzz is so crazy. > > We should add a comment or text re: "this test passes if it does not crash." Done. Since we have been having a code to remove empty bounds, there should be other cases to make it happen, but at least in this case, closing tags properly stops hitting this bug. But the fix looks proper to me, so it's good (although I agree we should have better test case ;)
	14 <textPath>

	15 <script>

	16 if (window.testRunner)

	17 testRunner.dumpAsText();

	18 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash-expected.txt » ('j') | no next file with comments »