Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPainter.cpp

Issue 1481483002: Fix crash in ObjectPainter::paintOutline in flipped blocks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebaseline Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/ObjectPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
index 987f6806f4c3d7ee848cc3fcbfca6b8082752404..a05c989094b88d2990a5c49c1dd4e800af91561a 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
@@ -211,8 +211,11 @@ void ObjectPainter::paintOutline(const PaintInfo& paintInfo, const LayoutPoint&
// Block flipping is not applied yet if !m_layoutObject.isBox().
if (!m_layoutObject.isBox() && m_layoutObject.styleRef().isFlippedBlocksWritingMode()) {
LayoutBlock* container = m_layoutObject.containingBlock();
- if (container)
+ if (container) {
m_layoutObject.localToContainerRects(outlineRects, container, -paintOffset, paintOffset);
+ if (outlineRects.isEmpty())
+ return;
+ }
}
Vector<IntRect> pixelSnappedOutlineRects;
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-outline-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698