Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1480953002: Drop [LegacyInterfaceTypeChecking] where trivial in WebRTC (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] where trivial in WebRTC The extra type checking in the bindings of the MediaStream constructor and RTCDataChannel's send() methods is actually not observable, because there is type testing to determine which override to use that makes sure those code paths aren't reached if the types aren't correct. For each method affected, it was verified using cs.chromium.org that there are no internal calls where nullptr could be passed, the only calls were from bindings an unit tests. BUG=561338 Committed: https://crrev.com/027253cdbbe06eb7c2352b5146c4f5a60515940c Cr-Commit-Position: refs/heads/master@{#362024}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 5 chunks +5 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
philipj_slow
PTAL. More reviewers than usual because I suspect that hta@ and guidou@ will be most ...
5 years ago (2015-11-27 14:32:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480953002/20001
5 years ago (2015-11-27 14:33:16 UTC) #5
Guido Urdaneta
lgtm
5 years ago (2015-11-27 14:39:32 UTC) #6
Peter Beverloo
On 2015/11/27 14:39:32, Guido Urdaneta wrote: > lgtm Stampedy stamp lgtm - thanks for the ...
5 years ago (2015-11-27 14:42:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 15:46:50 UTC) #9
tommi (sloooow) - chröme
rs lgtm
5 years ago (2015-11-27 17:17:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480953002/20001
5 years ago (2015-11-27 17:57:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 18:03:49 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-27 18:04:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/027253cdbbe06eb7c2352b5146c4f5a60515940c
Cr-Commit-Position: refs/heads/master@{#362024}

Powered by Google App Engine
This is Rietveld 408576698