Chromium Code Reviews

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 1480953002: Drop [LegacyInterfaceTypeChecking] where trivial in WebRTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
index 60e0ba9a49a03cfbb3a01f5b365f75e9706a51a8..f42c7b37367bc7e020bc2b788667577ee269d925 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
@@ -82,7 +82,7 @@ enum RTCIceConnectionState {
// readonly attribute RTCSessionDescription? currentRemoteDescription;
// readonly attribute RTCSessionDescription? pendingRemoteDescription;
// TODO(guidou): addIceCandidate() should return a Promise.
- [RaisesException, LegacyInterfaceTypeChecking] void addIceCandidate(RTCIceCandidate candidate);
+ [RaisesException] void addIceCandidate(RTCIceCandidate candidate);
readonly attribute RTCSignalingState signalingState;
readonly attribute RTCIceGatheringState iceGatheringState;
readonly attribute RTCIceConnectionState iceConnectionState;
@@ -101,14 +101,14 @@ enum RTCIceConnectionState {
// TODO(guidou): The failureCallback argument should be non-optional.
[RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);
// TODO(guidou): None of the arguments should be optional.
- [RaisesException, LegacyInterfaceTypeChecking] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
+ [RaisesException] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
// TODO(guidou): The failureCallback argument should be non-optional, and
// there should be no mediaConstraints argument.
[RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);
// TODO(guidou): The successCallback and failureCallback arguments should be
// non-optional.
- [RaisesException, LegacyInterfaceTypeChecking] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
- [RaisesException, LegacyInterfaceTypeChecking] void addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCErrorCallback failureCallback);
+ [RaisesException] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
+ [RaisesException] void addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCErrorCallback failureCallback);
// TODO(guidou): The selector argument should the first (nullable,
// non-optional) argument, and there should be a third failureCallback
// argument.
@@ -127,7 +127,7 @@ enum RTCIceConnectionState {
MediaStream getStreamById(DOMString streamId);
[RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
[RaisesException] void removeStream(MediaStream? stream);
- [RaisesException, LegacyInterfaceTypeChecking] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
+ [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
attribute EventHandler onaddstream;
attribute EventHandler onremovestream;
« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine