third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html - Issue 1480953002: Drop [LegacyInterfaceTypeChecking] where trivial in WebRTC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

Issue 1480953002: Drop [LegacyInterfaceTypeChecking] where trivial in WebRTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

index f489753ca36b69a5dca30943b75455ca8a651a58..f144b9dacfd2914c80f0bf16aa68e458ad49eaf0 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

@@ -36,8 +36,8 @@ function onIceChange1()

if (pc.iceConnectionState === "completed") {

testPassed("iceConnectionState is completed");

iceCandidate = new RTCIceCandidate({candidate:"nano nano"});

- shouldThrow('pc.addIceCandidate(null, null, null);');

- shouldThrow('pc.addIceCandidate(iceCandidate, null, null);');

+ shouldThrow('pc.addIceCandidate(null, addIceCandidateSuccess, addIceCandidateFailure);');

+ shouldThrow('pc.addIceCandidate(iceCandidate, null, addIceCandidateFailure);');

shouldThrow('pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, null);');

shouldNotThrow('pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, addIceCandidateFailure);');

}