Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Never call CpuFeatures::FlushICache directly Always go through Assembler::FlushICache so we automatically use the simulator when running with a simulator. BUG=v8:2487 R=epertoso@chromium.org LOG=n Committed: https://crrev.com/8d90b92737018a54c483304c017901af1580abf1 Cr-Commit-Position: refs/heads/master@{#32300}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -38 lines) Patch
M src/assembler.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/cpu-mips.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/cpu-mips64.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-25 15:22:57 UTC) #1
epertoso
lgtm
5 years ago (2015-11-25 15:35:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480623002/40001
5 years ago (2015-11-25 18:32:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-25 19:27:27 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 19:27:41 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8d90b92737018a54c483304c017901af1580abf1
Cr-Commit-Position: refs/heads/master@{#32300}

Powered by Google App Engine
This is Rietveld 408576698