Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: src/mips/code-stubs-mips.h

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/mips/codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_MIPS_CODE_STUBS_MIPS_H_ 5 #ifndef V8_MIPS_CODE_STUBS_MIPS_H_
6 #define V8_MIPS_CODE_STUBS_MIPS_H_ 6 #define V8_MIPS_CODE_STUBS_MIPS_H_
7 7
8 #include "src/mips/frames-mips.h" 8 #include "src/mips/frames-mips.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 case INCREMENTAL: 152 case INCREMENTAL:
153 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY); 153 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY);
154 PatchNopIntoBranch(&masm, 0); 154 PatchNopIntoBranch(&masm, 0);
155 break; 155 break;
156 case INCREMENTAL_COMPACTION: 156 case INCREMENTAL_COMPACTION:
157 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY); 157 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY);
158 PatchNopIntoBranch(&masm, 2 * Assembler::kInstrSize); 158 PatchNopIntoBranch(&masm, 2 * Assembler::kInstrSize);
159 break; 159 break;
160 } 160 }
161 DCHECK(GetMode(stub) == mode); 161 DCHECK(GetMode(stub) == mode);
162 CpuFeatures::FlushICache(stub->instruction_start(), 162 Assembler::FlushICache(stub->GetIsolate(), stub->instruction_start(),
163 4 * Assembler::kInstrSize); 163 4 * Assembler::kInstrSize);
164 } 164 }
165 165
166 DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(); 166 DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR();
167 167
168 private: 168 private:
169 // This is a helper class for freeing up 3 scratch registers. The input is 169 // This is a helper class for freeing up 3 scratch registers. The input is
170 // two registers that must be preserved and one scratch register provided by 170 // two registers that must be preserved and one scratch register provided by
171 // the caller. 171 // the caller.
172 class RegisterAllocation { 172 class RegisterAllocation {
173 public: 173 public:
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 339
340 DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(); 340 DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR();
341 DEFINE_PLATFORM_CODE_STUB(NameDictionaryLookup, PlatformCodeStub); 341 DEFINE_PLATFORM_CODE_STUB(NameDictionaryLookup, PlatformCodeStub);
342 }; 342 };
343 343
344 344
345 } // namespace internal 345 } // namespace internal
346 } // namespace v8 346 } // namespace v8
347 347
348 #endif // V8_MIPS_CODE_STUBS_MIPS_H_ 348 #endif // V8_MIPS_CODE_STUBS_MIPS_H_
OLDNEW
« no previous file with comments | « src/mips/assembler-mips-inl.h ('k') | src/mips/codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698