Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/assembler.h

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips/assembler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 static inline bool SupportsCrankshaft(); 229 static inline bool SupportsCrankshaft();
230 230
231 static inline unsigned cache_line_size() { 231 static inline unsigned cache_line_size() {
232 DCHECK(cache_line_size_ != 0); 232 DCHECK(cache_line_size_ != 0);
233 return cache_line_size_; 233 return cache_line_size_;
234 } 234 }
235 235
236 static void PrintTarget(); 236 static void PrintTarget();
237 static void PrintFeatures(); 237 static void PrintFeatures();
238 238
239 private:
240 friend class ExternalReference;
241 friend class AssemblerBase;
239 // Flush instruction cache. 242 // Flush instruction cache.
240 static void FlushICache(void* start, size_t size); 243 static void FlushICache(void* start, size_t size);
241 244
242 private:
243 // Platform-dependent implementation. 245 // Platform-dependent implementation.
244 static void ProbeImpl(bool cross_compile); 246 static void ProbeImpl(bool cross_compile);
245 247
246 static unsigned supported_; 248 static unsigned supported_;
247 static unsigned cache_line_size_; 249 static unsigned cache_line_size_;
248 static bool initialized_; 250 static bool initialized_;
249 friend class ExternalReference;
250 DISALLOW_COPY_AND_ASSIGN(CpuFeatures); 251 DISALLOW_COPY_AND_ASSIGN(CpuFeatures);
251 }; 252 };
252 253
253 254
254 // ----------------------------------------------------------------------------- 255 // -----------------------------------------------------------------------------
255 // Labels represent pc locations; they are typically jump or call targets. 256 // Labels represent pc locations; they are typically jump or call targets.
256 // After declaration, a label can be freely used to denote known or (yet) 257 // After declaration, a label can be freely used to denote known or (yet)
257 // unknown pc location. Assembler::bind() is used to bind a label to the 258 // unknown pc location. Assembler::bind() is used to bind a label to the
258 // current pc. A label can be bound only once. 259 // current pc. A label can be bound only once.
259 260
(...skipping 1032 matching lines...) Expand 10 before | Expand all | Expand 10 after
1292 std::vector<ConstantPoolEntry> shared_entries; 1293 std::vector<ConstantPoolEntry> shared_entries;
1293 }; 1294 };
1294 1295
1295 Label emitted_label_; // Records pc_offset of emitted pool 1296 Label emitted_label_; // Records pc_offset of emitted pool
1296 PerTypeEntryInfo info_[ConstantPoolEntry::NUMBER_OF_TYPES]; 1297 PerTypeEntryInfo info_[ConstantPoolEntry::NUMBER_OF_TYPES];
1297 }; 1298 };
1298 1299
1299 } // namespace internal 1300 } // namespace internal
1300 } // namespace v8 1301 } // namespace v8
1301 #endif // V8_ASSEMBLER_H_ 1302 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « no previous file | src/mips/assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698