Issue 1480603002: Revert "Ensure that a complete library element has constants evaluated (issue 24890)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1480603002: Revert "Ensure that a complete library element has constants evaluated (issue 24890)" (Closed)

Created:
5 years ago by Brian Wilkerson

Modified:
5 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Ensure that a complete library element has constants evaluated (issue 24890)" Committed: https://github.com/dart-lang/sdk/commit/e94c8204118abea7f3fc73bf8c88d4bee48bffa9

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -123 lines)			Patch
M	pkg/analyzer/lib/src/context/context.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	8 chunks	+7 lines, -84 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	3 chunks	+0 lines, -28 lines	0 comments	Download
M	pkg/analyzer/tool/task_dependency_graph/tasks.dot	View	4 chunks	+3 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Committed patchset #1 (id:1) manually as e94c8204118abea7f3fc73bf8c88d4bee48bffa9 (presubmit successful).

5 years ago (2015-11-25 15:13:13 UTC) #1

Brian Wilkerson

The reverted CL caused failures that were not there yesterday.

5 years ago (2015-11-25 15:13:55 UTC) #3

Message was sent while issue was closed.

LGTM