Revert "Ensure that a complete library element has constants evaluated (issue 24890)"

pkg/analyzer/tool/task_dependency_graph/tasks.dot

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // This file has been automatically generated.  Please do not edit it manually.
 // To regenerate the file, use the script
 // "pkg/analyzer/tool/task_dependency_graph/generate.dart".
 //
 // To render this graph using Graphviz (www.graphviz.org) use the command:
 // "dot tasks.dot -Tpdf -O".
@@ skipping 83 matching lines @@
   LIBRARY_CYCLE [shape=box]
   LIBRARY_CYCLE_DEPENDENCIES -> InferInstanceMembersInUnitTask
   LIBRARY_CYCLE_DEPENDENCIES -> InferStaticVariableTypeTask
   LIBRARY_CYCLE_DEPENDENCIES -> PartiallyResolveUnitReferencesTask
   LIBRARY_CYCLE_DEPENDENCIES -> ResolveInstanceFieldsInUnitTask
   LIBRARY_CYCLE_DEPENDENCIES [shape=box]
   LIBRARY_CYCLE_UNITS -> InferInstanceMembersInUnitTask
   LIBRARY_CYCLE_UNITS -> ResolveInstanceFieldsInUnitTask
   LIBRARY_CYCLE_UNITS -> ResolveUnitTask
   LIBRARY_CYCLE_UNITS [shape=box]
-  LIBRARY_ELEMENT -> LibraryErrorsReadyTask
+  LIBRARY_ELEMENT -> EvaluateUnitConstantsTask
   LIBRARY_ELEMENT [shape=box]
   LIBRARY_ELEMENT1 -> BuildDirectiveElementsTask
   LIBRARY_ELEMENT1 -> ResolveVariableReferencesTask
   LIBRARY_ELEMENT1 [shape=box]
   LIBRARY_ELEMENT2 -> BuildPublicNamespaceTask
   LIBRARY_ELEMENT2 -> BuildSourceExportClosureTask
   LIBRARY_ELEMENT2 -> ComputeLibraryCycleTask
   LIBRARY_ELEMENT2 -> ReadyLibraryElement2Task
   LIBRARY_ELEMENT2 [shape=box]
   LIBRARY_ELEMENT3 -> BuildExportNamespaceTask
   LIBRARY_ELEMENT3 -> BuildTypeProviderTask
   LIBRARY_ELEMENT3 [shape=box]
   LIBRARY_ELEMENT4 -> ResolveLibraryTypeNamesTask
   LIBRARY_ELEMENT4 -> ResolveUnitTypeNamesTask
   LIBRARY_ELEMENT4 [shape=box]
   LIBRARY_ELEMENT5 -> PartiallyResolveUnitReferencesTask
   LIBRARY_ELEMENT5 -> PropagateVariableTypesInLibraryTask
   LIBRARY_ELEMENT5 -> ReadyLibraryElement5Task
   LIBRARY_ELEMENT5 -> ResolveInstanceFieldsInUnitTask
+  LIBRARY_ELEMENT5 -> ResolveLibraryReferencesTask
   LIBRARY_ELEMENT5 [shape=box]
   LIBRARY_ELEMENT6 -> PropagateVariableTypesInLibraryClosureTask
   LIBRARY_ELEMENT6 -> ReadyLibraryElement6Task
   LIBRARY_ELEMENT6 [shape=box]
-  LIBRARY_ELEMENT7 -> ResolveLibraryReferencesTask
   LIBRARY_ELEMENT7 -> ResolveUnitTask
   LIBRARY_ELEMENT7 [shape=box]
-  LIBRARY_ELEMENT8 -> EvaluateUnitConstantsTask
-  LIBRARY_ELEMENT8 -> ResolveLibraryTask
-  LIBRARY_ELEMENT8 [shape=box]
   LIBRARY_ERRORS_READY [shape=box]
   LIBRARY_SPECIFIC_UNITS -> GenerateHintsTask
   LIBRARY_SPECIFIC_UNITS -> PropagateVariableTypesInLibraryTask
   LIBRARY_SPECIFIC_UNITS -> ReadyResolvedUnit10Task
   LIBRARY_SPECIFIC_UNITS -> ReadyResolvedUnit11Task
   LIBRARY_SPECIFIC_UNITS -> ReadyResolvedUnitTask
   LIBRARY_SPECIFIC_UNITS -> ResolveLibraryReferencesTask
   LIBRARY_SPECIFIC_UNITS -> ResolveLibraryTypeNamesTask
   LIBRARY_SPECIFIC_UNITS [shape=box]
   LIBRARY_UNIT_ERRORS -> dartErrorsForUnit
@@ skipping 36 matching lines @@
   READY_LIBRARY_ELEMENT2 -> ComputeLibraryCycleTask
   READY_LIBRARY_ELEMENT2 -> ReadyLibraryElement2Task
   READY_LIBRARY_ELEMENT2 [shape=box]
   READY_LIBRARY_ELEMENT5 -> PartiallyResolveUnitReferencesTask
   READY_LIBRARY_ELEMENT5 -> ReadyLibraryElement5Task
   READY_LIBRARY_ELEMENT5 [shape=box]
   READY_LIBRARY_ELEMENT6 -> PropagateVariableTypesInLibraryClosureTask
   READY_LIBRARY_ELEMENT6 -> ReadyLibraryElement6Task
   READY_LIBRARY_ELEMENT6 [shape=box]
   READY_RESOLVED_UNIT -> ReadyResolvedUnitTask
-  READY_RESOLVED_UNIT -> ResolveLibraryTask
   READY_RESOLVED_UNIT -> VerifyUnitTask
   READY_RESOLVED_UNIT [shape=box]
   READY_RESOLVED_UNIT10 -> ReadyResolvedUnit10Task
   READY_RESOLVED_UNIT10 -> ResolveLibraryReferencesTask
   READY_RESOLVED_UNIT10 [shape=box]
   READY_RESOLVED_UNIT11 -> ReadyResolvedUnit11Task
   READY_RESOLVED_UNIT11 -> StrongModeVerifyUnitTask
   READY_RESOLVED_UNIT11 [shape=box]
   REFERENCED_NAMES [shape=box]
   RESOLVED_UNIT -> GenerateHintsTask
@@ skipping 45 matching lines @@
   RESOLVE_TYPE_NAMES_ERRORS [shape=box]
   RESOLVE_UNIT_ERRORS -> LibraryUnitErrorsTask
   RESOLVE_UNIT_ERRORS [shape=box]
   ReadyLibraryElement2Task -> READY_LIBRARY_ELEMENT2
   ReadyLibraryElement5Task -> READY_LIBRARY_ELEMENT5
   ReadyLibraryElement6Task -> READY_LIBRARY_ELEMENT6
   ReadyResolvedUnit10Task -> READY_RESOLVED_UNIT10
   ReadyResolvedUnit11Task -> READY_RESOLVED_UNIT11
   ReadyResolvedUnitTask -> READY_RESOLVED_UNIT
   ResolveInstanceFieldsInUnitTask -> RESOLVED_UNIT8
-  ResolveLibraryReferencesTask -> LIBRARY_ELEMENT8
+  ResolveLibraryReferencesTask -> LIBRARY_ELEMENT
   ResolveLibraryReferencesTask -> REFERENCED_NAMES
-  ResolveLibraryTask -> LIBRARY_ELEMENT
   ResolveLibraryTypeNamesTask -> LIBRARY_ELEMENT5
   ResolveUnitTask -> RESOLVED_UNIT10
   ResolveUnitTask -> RESOLVE_UNIT_ERRORS
   ResolveUnitTypeNamesTask -> RESOLVED_UNIT3
   ResolveUnitTypeNamesTask -> RESOLVE_TYPE_NAMES_ERRORS
   ResolveVariableReferencesTask -> RESOLVED_UNIT4
   ResolveVariableReferencesTask -> VARIABLE_REFERENCE_ERRORS
   SCAN_ERRORS -> dartErrorsForSource
   SCAN_ERRORS [shape=box]
   SOURCE_KIND -> BuildDirectiveElementsTask
@@ skipping 32 matching lines @@
   VARIABLE_REFERENCE_ERRORS -> LibraryUnitErrorsTask
   VARIABLE_REFERENCE_ERRORS [shape=box]
   VERIFY_ERRORS -> LibraryUnitErrorsTask
   VERIFY_ERRORS [shape=box]
   VerifyUnitTask -> VERIFY_ERRORS
   dartErrorsForSource -> DartErrorsTask
   dartErrorsForSource [shape=hexagon]
   dartErrorsForUnit -> DartErrorsTask
   dartErrorsForUnit [shape=hexagon]
 }