Revert "Ensure that a complete library element has constants evaluated (issue 24890)"

pkg/analyzer/test/src/context/context_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.context.context_test;
 
 import 'dart:async';
 
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
@@ skipping 310 matching lines @@
 import 'libB.dart';''';
     Source libA = addSource("/libA.dart", libAContents);
     String libBContents = "library libB;";
     Source libB = addSource("/libB.dart", libBContents);
     LibraryElement libAElement = context.computeLibraryElement(libA);
     expect(libAElement, isNotNull);
     List<LibraryElement> importedLibraries = libAElement.importedLibraries;
     expect(importedLibraries, hasLength(2));
     context.computeErrors(libA);
     context.computeErrors(libB);
+    expect(context.sourcesNeedingProcessing, hasLength(0));
     context.setContents(libB, null);
     _removeSource(libB);
     List<Source> sources = context.sourcesNeedingProcessing;
     expect(sources, hasLength(1));
     expect(sources[0], same(libA));
     libAElement = context.computeLibraryElement(libA);
     importedLibraries = libAElement.importedLibraries;
     expect(importedLibraries, hasLength(1));
     return pumpEventQueue().then((_) {
       listener.assertEvent(wereSourcesAdded: true);
@@ skipping 49 matching lines @@
     context.onSourcesChanged.listen(listener.onData);
     String libAContents = r'''
 library libA;
 import 'libB.dart';''';
     Source libA = addSource("/libA.dart", libAContents);
     String libBContents = "library libB;";
     Source libB = addSource("/libB.dart", libBContents);
     context.computeLibraryElement(libA);
     context.computeErrors(libA);
     context.computeErrors(libB);
+    expect(context.sourcesNeedingProcessing, hasLength(0));
     ChangeSet changeSet = new ChangeSet();
     SourceContainer removedContainer =
         new _AnalysisContextImplTest_test_applyChanges_removeContainer(libB);
     changeSet.removedContainer(removedContainer);
     context.applyChanges(changeSet);
     List<Source> sources = context.sourcesNeedingProcessing;
     expect(sources, hasLength(1));
     expect(sources[0], same(libA));
     return pumpEventQueue().then((_) {
       listener.assertEvent(wereSourcesAdded: true);
@@ skipping 1545 matching lines @@
     });
     context.onResultComputed(RESOLVED_UNIT).listen((event) {
       LibrarySpecificUnit target = event.target;
       Source librarySource = target.library;
       resolvedUnitUris.add(librarySource.uri.toString());
     });
     // analyze
     addSource('/test.dart', 'main() {}');
     _analyzeAll_assertFinished();
     // verify
+    expect(libraryElementUris, contains('dart:core'));
     expect(libraryElementUris, contains('file:///test.dart'));
     expect(parsedUnitUris, contains('dart:core'));
     expect(parsedUnitUris, contains('file:///test.dart'));
     expect(resolvedUnitUris, contains('dart:core'));
     expect(resolvedUnitUris, contains('file:///test.dart'));
   }
 
   void test_performAnalysisTask_switchPackageVersion() {
     // version 1
     resourceProvider.newFile(
@@ skipping 749 matching lines @@
   }
 }
 
 class _AnalysisContextImplTest_test_applyChanges_removeContainer
     implements SourceContainer {
   Source libB;
   _AnalysisContextImplTest_test_applyChanges_removeContainer(this.libB);
   @override
   bool contains(Source source) => source == libB;
 }