src/ia32/code-stubs-ia32.cc - Issue 14803005: Erroneous pointer/smi comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 14803005: Erroneous pointer/smi comparison (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Now, in all platforms Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index b168ad50d6b80b5cbf43484d7a4bf4beb38eb876..bfa49d51d0ac4e3dfdd458f26e1bcc9d2f5fd86a 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -4775,6 +4775,7 @@ static void GenerateRecordCallTarget(MacroAssembler* masm) {

Handle<Object> terminal_kind_sentinel =

TypeFeedbackCells::MonomorphicArraySentinel(isolate,

LAST_FAST_ELEMENTS_KIND);

+ __ JumpIfNotSmi(ecx, &miss);

__ cmp(ecx, Immediate(terminal_kind_sentinel));

__ j(above, &miss);

// Load the global or builtins object from the current context

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »