Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 14803005: Erroneous pointer/smi comparison (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Now, in all platforms Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4757 matching lines...) Expand 10 before | Expand all | Expand 10 after
4768 __ j(equal, &done); 4768 __ j(equal, &done);
4769 __ cmp(ecx, Immediate(TypeFeedbackCells::MegamorphicSentinel(isolate))); 4769 __ cmp(ecx, Immediate(TypeFeedbackCells::MegamorphicSentinel(isolate)));
4770 __ j(equal, &done); 4770 __ j(equal, &done);
4771 4771
4772 // Special handling of the Array() function, which caches not only the 4772 // Special handling of the Array() function, which caches not only the
4773 // monomorphic Array function but the initial ElementsKind with special 4773 // monomorphic Array function but the initial ElementsKind with special
4774 // sentinels 4774 // sentinels
4775 Handle<Object> terminal_kind_sentinel = 4775 Handle<Object> terminal_kind_sentinel =
4776 TypeFeedbackCells::MonomorphicArraySentinel(isolate, 4776 TypeFeedbackCells::MonomorphicArraySentinel(isolate,
4777 LAST_FAST_ELEMENTS_KIND); 4777 LAST_FAST_ELEMENTS_KIND);
4778 __ JumpIfNotSmi(ecx, &miss);
4778 __ cmp(ecx, Immediate(terminal_kind_sentinel)); 4779 __ cmp(ecx, Immediate(terminal_kind_sentinel));
4779 __ j(above, &miss); 4780 __ j(above, &miss);
4780 // Load the global or builtins object from the current context 4781 // Load the global or builtins object from the current context
4781 __ LoadGlobalContext(ecx); 4782 __ LoadGlobalContext(ecx);
4782 // Make sure the function is the Array() function 4783 // Make sure the function is the Array() function
4783 __ cmp(edi, Operand(ecx, 4784 __ cmp(edi, Operand(ecx,
4784 Context::SlotOffset(Context::ARRAY_FUNCTION_INDEX))); 4785 Context::SlotOffset(Context::ARRAY_FUNCTION_INDEX)));
4785 __ j(not_equal, &megamorphic); 4786 __ j(not_equal, &megamorphic);
4786 __ jmp(&done); 4787 __ jmp(&done);
4787 4788
(...skipping 3182 matching lines...) Expand 10 before | Expand all | Expand 10 after
7970 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET); 7971 __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET);
7971 } 7972 }
7972 } 7973 }
7973 7974
7974 7975
7975 #undef __ 7976 #undef __
7976 7977
7977 } } // namespace v8::internal 7978 } } // namespace v8::internal
7978 7979
7979 #endif // V8_TARGET_ARCH_IA32 7980 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698