src/x64/code-stubs-x64.cc - Issue 14803005: Erroneous pointer/smi comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 14803005: Erroneous pointer/smi comparison (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Now, in all platforms Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index ed0a24043af586784e5f9483b2fc4978c024e029..9122c02f323a599ae671e2b8730cca644b14ecd1 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -3835,6 +3835,7 @@ static void GenerateRecordCallTarget(MacroAssembler* masm) {

Handle<Object> terminal_kind_sentinel =

TypeFeedbackCells::MonomorphicArraySentinel(isolate,

LAST_FAST_ELEMENTS_KIND);

+ __ JumpIfNotSmi(rcx, &miss);

__ Cmp(rcx, terminal_kind_sentinel);

__ j(above, &miss);

// Make sure the function is the Array() function

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »