[WIP] Call WebTestProxyBase::CheckDone() in didStopLoading()

Call WebTestProxyBase::CheckDone() in didStopLoading()

This CL is preparation for [1].

test_runner::WebTestProxyBase::CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
when shouldSendCompleteNotification() is true.

However, [1] calls FrameLoader::checkCompleted() asynchronously and thus makes
it slightly later.
In such cases, shouldSendCompleteNotification() can be false when
checkCompleted() is called because e.g. the corresponding Document is already
notified, CheckDone() is not called and thus layout tests are not terminated.

This CL calls CheckDone() also from:
   test_runner::WebTestProxyBase::DidStopLoading()
   test_runner::WebFrameTestProxy<>::didStopLoading()
   blink::ProgressTracker::progressCompleted()
   blink::FrameLoader::checkCompleted()
when shouldSendCompleteNotification() is true.
To do this, |WebLocalFrame*| parameter is added to
WebFrameClient::didStopLoading() and its overrides.

[1] https://codereview.chromium.org/1475863005/


TEST=fast/frames/frame-set-same-src.html
BUG=569511

[hiroshige, 2015-11-27 14:25:33]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 14:26:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/1

[commit-bot: I haz the power, 2015-11-27 14:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 14:56:26]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2015-11-27 14:57:19]

Description was changed from

==========
Skip setTopLoadingFrame() except for the first one

BUG=
==========

to

==========
Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.
==========

[hiroshige, 2015-11-27 14:59:05]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 14:59:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/20001

[hiroshige, 2015-11-27 15:00:51]

Description was changed from

==========
Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.
==========

to

==========
Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.

TEST=fast/frames/frame-set-same-src.html
==========

[hiroshige, 2015-11-27 16:08:09]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 16:08:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/40001

[hiroshige, 2015-11-27 16:13:53]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2015-11-27 16:24:32]

Description was changed from

==========
Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.

TEST=fast/frames/frame-set-same-src.html
==========

to

==========
Memo (to be updated):

Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.

TEST=fast/frames/frame-set-same-src.html
==========

[hiroshige, 2015-11-27 16:32:24]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 16:33:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/60001

[commit-bot: I haz the power, 2015-11-27 17:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 17:44:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2015-11-27 17:58:46]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 17:59:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/80001

[commit-bot: I haz the power, 2015-11-27 18:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 18:46:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2015-11-30 07:43:06]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 07:43:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/100001

[commit-bot: I haz the power, 2015-11-30 07:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 07:50:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hiroshige, 2015-11-30 08:52:21]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 08:52:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/120001

[hiroshige, 2015-11-30 08:57:50]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 08:58:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/140001

[hiroshige, 2015-11-30 09:12:58]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 09:13:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/180001

[commit-bot: I haz the power, 2015-11-30 10:16:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 10:16:36]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2015-12-04 10:48:28]

Description was changed from

==========
Memo (to be updated):

Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.

TEST=fast/frames/frame-set-same-src.html
==========

to

==========
[WIP] Call CheckDone() in WebTestProxyBase::DidStopLoading()

CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
but this is not called e.g. corresponding Document is already notified, and
tests are not terminated.
This CL CheckDone() also in DidStopLoading().

Memo (to be updated):

Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.

TEST=fast/frames/frame-set-same-src.html
==========

[hiroshige, 2015-12-11 07:31:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-11 07:32:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/200001

[commit-bot: I haz the power, 2015-12-11 08:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 08:52:55]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2015-12-14 04:46:12]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-14 04:46:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/220001

[commit-bot: I haz the power, 2015-12-14 05:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-14 05:51:03]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2015-12-14 06:18:11]

Description was changed from

==========
[WIP] Call CheckDone() in WebTestProxyBase::DidStopLoading()

CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
but this is not called e.g. corresponding Document is already notified, and
tests are not terminated.
This CL CheckDone() also in DidStopLoading().

Memo (to be updated):

Set |TestRunner::top_loading_frame_| non-null only at the first attempt

|TestRunner::top_loading_frame_| can be set to non-main-resource frames e.g.
<frame> elements, but this causes
- testRunner.waitUntilDone() to be blocked by such non-main-resource frames, and
- Tests are not completed in the following scenario:
1. FrameLoader::load() is called for the main resource.
   TestRunner::setTopLoadingFrame(frame, false) is called from the following
   stack trace and |top_loading_frame_| is set to non-null:
      test_runner::TestRunner::setTopLoadingFrame()
      test_runner::WebTestProxyBase::DidStartProvisionalLoad()
      test_runner::WebFrameTestProxy<>::didStartProvisionalLoad()
      blink::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()
      blink::FrameLoader::startLoad()
      blink::FrameLoader::load()
2. FrameLoader::checkCompleted() is called for the main resource and
   TestRunner::setTopLoadingFrame(frame, true) is called from the following:
   stack trace and |top_loading_frame_| is set to null:
       test_runner::WebTestProxyBase::CheckDone()
       test_runner::WebTestProxyBase::DidFinishLoad()
       test_runner::WebFrameTestProxy<>::didFinishLoad()
       blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
       blink::FrameLoader::checkCompleted().
3. FrameLoader::load() is called for a <frame> element and
   stack trace and |top_loading_frame_| is set to non-null again.
4. TestRunner::NotifyDone() is called from JavaScript, but TestFinished() is
   not called because |top_loading_frame_| is set to non-null by Step 3.
5. FrameLoader::checkCompleted() is called for the <frame> element
   but TestRunner is not notified (and thus the test doesn't complete anymore)
   because shouldSendFinishNotification() returns false
   because DocumentLoader is already notified in Step 2.

This CL sets |TestRunner::top_loading_frame_| only at the first attempt to set
it non-null (which is expected to the main resource) and thus resolves the
issues above.

To Do: create crbug, watch test failures, add a layout test, mention
dependencies.

TEST=fast/frames/frame-set-same-src.html
==========

to

==========
[WIP] Call CheckDone() in WebTestProxyBase::DidStopLoading()

CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
but this is not called e.g. corresponding Document is already notified, and
tests are not terminated.
This CL CheckDone() also in DidStopLoading().

TEST=fast/frames/frame-set-same-src.html
==========

[hiroshige, 2015-12-14 06:33:14]

Description was changed from

==========
[WIP] Call CheckDone() in WebTestProxyBase::DidStopLoading()

CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
but this is not called e.g. corresponding Document is already notified, and
tests are not terminated.
This CL CheckDone() also in DidStopLoading().

TEST=fast/frames/frame-set-same-src.html
==========

to

==========
[WIP] Call WebTestProxyBase::CheckDone() in didStopLoading()

test_runner::WebTestProxyBase::CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
when shouldSendCompleteNotification() is true.

However, this is not called e.g. when corresponding Document is already
notified, and thus tests are not terminated.

This CL calls CheckDone() from:
   test_runner::WebTestProxyBase::DidStopLoading()
   test_runner::WebFrameTestProxy<>::didStopLoading()
   blink::ProgressTracker::progressCompleted()
   blink::FrameLoader::checkCompleted()
also when shouldSendCompleteNotification() is true, and adds |WebLocalFrame*|
parameter to WebFrameClient::didStopLoading() and its overrides.

TEST=fast/frames/frame-set-same-src.html
BUG=
==========

[hiroshige, 2015-12-14 12:05:49]

Description was changed from

==========
[WIP] Call WebTestProxyBase::CheckDone() in didStopLoading()

test_runner::WebTestProxyBase::CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
when shouldSendCompleteNotification() is true.

However, this is not called e.g. when corresponding Document is already
notified, and thus tests are not terminated.

This CL calls CheckDone() from:
   test_runner::WebTestProxyBase::DidStopLoading()
   test_runner::WebFrameTestProxy<>::didStopLoading()
   blink::ProgressTracker::progressCompleted()
   blink::FrameLoader::checkCompleted()
also when shouldSendCompleteNotification() is true, and adds |WebLocalFrame*|
parameter to WebFrameClient::didStopLoading() and its overrides.

TEST=fast/frames/frame-set-same-src.html
BUG=
==========

to

==========
Call WebTestProxyBase::CheckDone() in didStopLoading()

This CL is preparation for [1].

test_runner::WebTestProxyBase::CheckDone() is called from:
   test_runner::WebTestProxyBase::DidFinishLoad()
   test_runner::WebFrameTestProxy<>::didFinishLoad()
   blink::FrameLoaderClientImpl::dispatchDidFinishLoad()
   blink::FrameLoader::checkCompleted()
when shouldSendCompleteNotification() is true.

However, [1] calls FrameLoader::checkCompleted() asynchronously and thus makes
it slightly later.
In such cases, shouldSendCompleteNotification() can be false when
checkCompleted() is called because e.g. the corresponding Document is already
notified, CheckDone() is not called and thus layout tests are not terminated.

This CL calls CheckDone() also from:
   test_runner::WebTestProxyBase::DidStopLoading()
   test_runner::WebFrameTestProxy<>::didStopLoading()
   blink::ProgressTracker::progressCompleted()
   blink::FrameLoader::checkCompleted()
when shouldSendCompleteNotification() is true.
To do this, |WebLocalFrame*| parameter is added to
WebFrameClient::didStopLoading() and its overrides.

[1] https://codereview.chromium.org/1475863005/


TEST=fast/frames/frame-set-same-src.html
BUG=569511
==========

[hiroshige, 2015-12-14 12:23:37]

hiroshige@chromium.org changed reviewers:
+ mkwst@chromium.org

[hiroshige, 2015-12-14 12:23:38]

mkwst@, could you take a look as a components/test_runner OWNER?

[Mike West, 2015-12-14 20:25:10]

On 2015/12/14 at 12:23:38, hiroshige wrote:
> mkwst@, could you take a look as a components/test_runner OWNER?

The explanation sounds cogent to me. The changes to test_runner, Source/web, and
public/web LGTM; you'll need someone else for the rest.

[hiroshige, 2015-12-15 05:22:39]

hiroshige@chromium.org changed reviewers:
+ jochen@chromium.org

[hiroshige, 2015-12-15 05:22:39]

jochen@, could you take a look at as a //components and //content OWNER?

[jochen (gone - plz use gerrit), 2015-12-16 08:52:03]

hum, so I support making the onload event asynchronous, that's great stuff.

However, I'm worried that we're adding a work around for the test runner here,
while potentially breaking the logic for the shipping product. Can you explain
why it's ok for content?

the idea for layout tests is that they're done once the load event was fired,
this will be changed with this. Can you explain why this won't be a problem?

[hiroshige, 2016-02-17 02:30:38]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 02:34:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480043002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480043002/280001

[commit-bot: I haz the power, 2016-02-17 04:02:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 04:02:04]

Dry run: This issue passed the CQ dry run.