Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 1480043002: [WIP] Call WebTestProxyBase::CheckDone() in didStopLoading() Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/test_runner/web_frame_test_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/renderer/print_web_view_helper.cc
diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index 91c72303c93818c2e93668d37be2479ac0c2f506..39105d7167e9626edd4ea472a9ba4826ae352b26 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -606,7 +606,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient,
private:
// blink::WebViewClient:
- void didStopLoading() override;
+ void didStopLoading(blink::WebLocalFrame*) override;
// TODO(ojan): Remove this override and have this class use a non-null
// layerTreeView.
bool allowsBrokenNullLayerTreeView() const override;
@@ -748,7 +748,7 @@ bool PrepareFrameAndViewForPrint::allowsBrokenNullLayerTreeView() const {
return true;
}
-void PrepareFrameAndViewForPrint::didStopLoading() {
+void PrepareFrameAndViewForPrint::didStopLoading(blink::WebLocalFrame*) {
DCHECK(!on_ready_.is_null());
// Don't call callback here, because it can delete |this| and WebView that is
// called didStopLoading.
« no previous file with comments | « no previous file | components/test_runner/web_frame_test_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698