third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/PointerEventManager.cpp ('K') | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

index 4153e44bf733c07c60ab6ed58a1e6f0fc348a47d..7fa821374467cd8a1fac9df5dd0dc9aa874765d0 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

@@ -6,6 +6,7 @@

#define RespondWithObserver_h

#include "core/dom/ContextLifecycleObserver.h"

+#include "core/events/EventTarget.h"

#include "modules/ModulesExport.h"

#include "platform/heap/Handle.h"

#include "public/platform/WebURLRequest.h"

@@ -28,7 +29,7 @@ public:

void contextDestroyed() override;

- void didDispatchEvent(bool defaultPrevented);

+ void didDispatchEvent(DispatchEventResult dispatchResult);

// Observes the promise and delays calling didHandleFetchEvent() until the

// given promise is resolved or rejected.