third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/PointerEventManager.cpp ('K') | « third_party/WebKit/Source/modules/notifications/Notification.h ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index f8e2f52555705570b67c6f74fb6045965ac4e918..40a8d9bae61bd91e1955ea14ae3dd380bbe40247 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -352,7 +352,7 @@ size_t Notification::maxActions()

return notificationManager()->maxActions();

}

-bool Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)

+DispatchEventResult Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)

{

ASSERT(executionContext()->isContextThread());

return EventTarget::dispatchEventInternal(event);