third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/PointerEventManager.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index 876eabf81badd1e15dc50ef718bd80df5041b009..6181337c4d61bd3eec5d384e3d219ee3dc98262e 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -145,13 +145,13 @@ void RespondWithObserver::contextDestroyed()

m_state = Done;

}

-void RespondWithObserver::didDispatchEvent(bool defaultPrevented)

+void RespondWithObserver::didDispatchEvent(DispatchEventResult dispatchResult)

{

ASSERT(executionContext());

if (m_state != Initial)

return;

- if (defaultPrevented) {

+ if (dispatchResult != DispatchEventResult::NotCanceled) {

responseWasRejected(WebServiceWorkerResponseErrorDefaultPrevented);

return;

}