Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1479483004: Allow in-object properties in JSArrayBuffer. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@in-obj-data-view-and-array-buffer-view
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow in-object properties in JSArrayBuffer. BUG=v8:4531 LOG=Y Committed: https://crrev.com/05449f741bf2f7f1c12891cd88b275b4dc983cf2 Cr-Commit-Position: refs/heads/master@{#32321}

Patch Set 1 #

Patch Set 2 : Test updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -46 lines) Patch
M src/objects.cc View 5 chunks +18 lines, -24 lines 0 comments Download
M src/objects-body-descriptors.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-body-descriptors-inl.h View 2 chunks +4 lines, -19 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 32 chunks +56 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1476753003 Patch 1

Dependent Patchsets:

Issue 1473323003 Patch 1

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479483004/1
5 years ago (2015-11-25 13:46:39 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-11-25 13:46:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479483004/20001
5 years ago (2015-11-25 14:05:07 UTC) #6
ulan
lgtm
5 years ago (2015-11-25 14:54:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 15:20:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479483004/20001
5 years ago (2015-11-26 09:44:22 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 09:45:54 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-26 09:46:09 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/05449f741bf2f7f1c12891cd88b275b4dc983cf2
Cr-Commit-Position: refs/heads/master@{#32321}

Powered by Google App Engine
This is Rietveld 408576698