Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 1476753003: Allow in-object properties in JSTypedArray and JSDataView. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@in-obj-weak-collections
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow in-object properties in JSTypedArray and JSDataView. This CL also removes JSTypedArray and JSDataView static visitor Ids because the visiting logic is the same as for ordinary JSObject. BUG=v8:4531 LOG=Y Committed: https://crrev.com/b711c31870c3688b2573e3fe1486c626b80c9b0d Cr-Commit-Position: refs/heads/master@{#32317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -68 lines) Patch
M src/heap/objects-visiting.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/heap/objects-visiting.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 4 chunks +0 lines, -48 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476753003/1
5 years ago (2015-11-25 12:40:32 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-11-25 12:41:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 13:18:55 UTC) #6
ulan
lgtm
5 years ago (2015-11-25 14:51:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476753003/1
5 years ago (2015-11-26 08:50:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 09:13:37 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 09:13:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b711c31870c3688b2573e3fe1486c626b80c9b0d
Cr-Commit-Position: refs/heads/master@{#32317}

Powered by Google App Engine
This is Rietveld 408576698