Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1473323003: Add test for Promises subclassing. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@in-obj-array-buffer-view
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add test for Promises subclassing. BUG=v8:3101, v8:3330 LOG=N Committed: https://crrev.com/5a3b4366cd69da96591005d2fec6f67a877f8f34 Cr-Commit-Position: refs/heads/master@{#32324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473323003/1
5 years ago (2015-11-25 16:56:52 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-11-25 16:56:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 19:21:34 UTC) #6
Toon Verwaest
lgtm
5 years ago (2015-11-26 10:11:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473323003/1
5 years ago (2015-11-26 10:11:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 10:27:15 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-26 10:28:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a3b4366cd69da96591005d2fec6f67a877f8f34
Cr-Commit-Position: refs/heads/master@{#32324}

Powered by Google App Engine
This is Rietveld 408576698