Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1479113002: [Oilpan] Replace a raw pointer with UntracedMember in RetainedDOMInfo (Closed)

Created:
5 years ago by peria
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace a raw pointer with UntracedMember in RetainedDOMInfo. Node requires a high performance, so we want to avoid using WeakPersistent. BUG=550325 Committed: https://crrev.com/c7deeacb4c4c5d8f8ade9d7c8ef9c459a8778166 Cr-Commit-Position: refs/heads/master@{#361960}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h View 1 chunk +1 line, -2 lines 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
peria
PTL
5 years ago (2015-11-27 05:00:03 UTC) #3
haraken
LGTM https://codereview.chromium.org/1479113002/diff/1/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h File third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h (right): https://codereview.chromium.org/1479113002/diff/1/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h#newcode60 third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h:60: RawPtrWillBeUntracedMember<Node> m_root; Yes, this pointer is pretty special ...
5 years ago (2015-11-27 05:11:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479113002/1
5 years ago (2015-11-27 05:25:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 08:17:10 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-27 08:17:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7deeacb4c4c5d8f8ade9d7c8ef9c459a8778166
Cr-Commit-Position: refs/heads/master@{#361960}

Powered by Google App Engine
This is Rietveld 408576698